There is one group that should disable Windows Search: people who live inside massive document repositories. If you’re a lawyer searching 500,000 contracts, a researcher with a terabyte of PDFs, or a photographer with 200,000 raw images—keep it on. The indexing is your friend.
For a surprising number of people, the answer is the latter. disable windows search